feat(openapi3filter): add ExludeRequestQuery #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekth
force-pushed
the
skip-parameters
branch
from
7409c6e
to
a937f93
Compare
fenollp
reviewed
Dec 8, 2023
openapi3filter/options.go
Outdated
| @@ -7,6 +7,9 @@ type Options struct { | |||
| // Set ExcludeRequestBody so ValidateRequest skips request body validation | |||
| ExcludeRequestBody bool | |||
|
|
|||
| // Set ExcludeRequestQuery so ValidateRequest skips request query params validation | |||
| ExcludeRequestQuery bool | |||
There was a problem hiding this comment.
LGTM. yup add a test that makes sure the flag works
I'd also prefer a more precise name such as ExcludeRequestQueryParams
There was a problem hiding this comment.
Ok cool, i'll update the PR then
zekth
force-pushed
the
skip-parameters
branch
from
a937f93
to
5ba2f0a
Compare
|
@fenollp updated and ready to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal of remediation of #855
Until we support the
deepObjectvalidation; here's a proposal of adding the skip of query like it's done forbody.This would offload the validation to the application layer
If this is ok for you @fenollp i'll add a test suite to validate the behavior