Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

Pressing Delete button at the end of the block deletes the whole block #218

Closed
janherman opened this issue Mar 3, 2020 · 7 comments
Closed
Labels
priority: high 🔥 Issue must be solved in the next release type: bug 🐛 Issue is a bug; PR is a bugfix

Comments

@janherman
Copy link

janherman commented Mar 3, 2020

Describe the bug
Pressing "Delete" button at the end of the block deletes the whole block. It happens with headings, paragraphs and list items.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new paragraph in editor. Put some content into it.
  2. Place the cursor at the end of the paragraph.
  3. Press "Delete" button.
  4. The whole block is deleted.

Expected bahavior:
I think this should not happen, when there is some content in the block.

Kirby Version
Kirby 3.3.4
Kirby Editor 1.0.2

@bastianallgeier
Copy link
Member

Which browser and OS do you use?

@bastianallgeier bastianallgeier added the missing: information ❓ Require more information before proceeding label Mar 5, 2020
@janherman
Copy link
Author

My OS is Windows 10. I tried different browsers (latest versions of Chrome, Firefox and Edge), it happens in every one of them.

@WebMechanic
Copy link

Same here, Firefox/74, Win10 Pro;
cms 3.3.4, editor 1.0.2

Hit "delete" in order to join two subsequent list items but instead the 1st got deleted.
Unfortunately classic "undo" (Ctrl-Z) doesn't work either which leaves me only with "Revert" to essentially destroy all edits made.

I need to revert my blueprints to use textarea again: the lack of undo and a killer-delete are absolute show stoppers.

@bastianallgeier bastianallgeier added priority: high 🔥 Issue must be solved in the next release type: bug 🐛 Issue is a bug; PR is a bugfix and removed missing: information ❓ Require more information before proceeding labels Mar 10, 2020
@bastianallgeier
Copy link
Member

@WebMechanic @janherman I totally agree that this is a big issue. It seems to be a Windows vs. Mac keyboard shortcut problem at first sight. This doesn't happen on a Mac. I will try to fix this asap.

@WebMechanic
Copy link

I switched to k-community/markdown-field for the time being which doesn't have this issue and also handles Undo properly

@seehat
Copy link

seehat commented May 14, 2020

Same here on a Mac:

  • Editor 1.0.2
  • Kirby 3.3.6
  • Chrome 81.0.4044.129

bastianallgeier added a commit that referenced this issue Jul 6, 2020
@bastianallgeier
Copy link
Member

I finally found a fix! ✅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: high 🔥 Issue must be solved in the next release type: bug 🐛 Issue is a bug; PR is a bugfix
Projects
None yet
Development

No branches or pull requests

4 participants