Update reference-classmethod.txt #2094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax `$results = $page->search('my awesome search', 'title|text');` throws the error `Kirby\Cms\Page::search(): Argument #2 ($params) must be of type array, string given, called in {…}` .
Needs to be `$results = $page->search('my awesome search', [ 'fields => [ 'title', 'text' ]]);` to succeed.
This is in Kirby 4.0.0-beta.1
|
@nilsmielke Isn't this than rather a bug in v4? We also shouldn't make v4 changes to the docs before v4 has been released. |
|
@distantnative Probably true. Unfortunately I do not have search set up in a k3 site right now. |
lukasbestle
added a commit
to getkirby/kirby
that referenced
this pull request
Sep 22, 2023
getkirby/getkirby.com#2094 `$collection->search()` already supports it, looks like we forgot to update this type hint when we switched from the type comment to the PHP type.
5 tasks
|
It's indeed a regression in v4. I've opened a core PR here: getkirby/kirby#5675 |
|
Thank you, @lukasbestle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax
$results = $page->search('my awesome search', 'title|text');throws the errorKirby\Cms\Page::search(): Argument #2 ($params) must be of type array, string given, called in {…}. Needs to be$results = $page->search('my awesome search', [ 'fields => [ 'title', 'text' ]]);to succeed.This is in Kirby 4.0.0-beta.1