-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File::setModel()
: Switch from class_uses()
to duck test
#4748
Milestone
Comments
This was referenced Oct 3, 2022
afbora
added a commit
that referenced
this issue
Oct 4, 2022
5 tasks
afbora
added a commit
that referenced
this issue
Oct 4, 2022
Co-Authored-By: Lukas Bestle <1595007+lukasbestle@users.noreply.github.com>
afbora
added a commit
that referenced
this issue
Oct 4, 2022
afbora
added a commit
that referenced
this issue
Oct 4, 2022
Co-Authored-By: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-Authored-By: Lukas Bestle <1595007+lukasbestle@users.noreply.github.com>
afbora
added a commit
that referenced
this issue
Oct 4, 2022
Co-Authored-By: Nico Hoffmann ෴. <3788865+distantnative@users.noreply.github.com> Co-Authored-By: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-Authored-By: Lukas Bestle <1595007+lukasbestle@users.noreply.github.com>
5 tasks
✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following lines cause a regression when a model class is extended in a plugin (because
class_uses()
does not check parents):kirby/src/Filesystem/File.php
Lines 447 to 449 in cfdba1b
Instead we want to check for the existence of the
root()
andurl()
methods.See mullema/k3-image-clip#25 for the original discussion.
The text was updated successfully, but these errors were encountered: