Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URLs and multiple custom panel styles/scripts #5180

Closed
lukaskleinschmidt opened this issue May 23, 2023 · 0 comments · Fixed by #5602
Closed

Allow URLs and multiple custom panel styles/scripts #5180

lukaskleinschmidt opened this issue May 23, 2023 · 0 comments · Fixed by #5602
Assignees
Milestone

Comments

@lukaskleinschmidt
Copy link
Contributor

Description

While working on a solution for this issue of my vite plugin I came across some shortcomings of the current custom panel styles/scripts implementation.

The shortcomings:

  1. You can only have a path to a file
  2. You can only define one file respectively

What would be nice to have:

  1. URL support for custom panel assets
  2. The possibility to add multiple assets

Reasons
In this case vite specific but most likely not limited to that.
To be able to make use of vites dev server or hot reloading you need to be able to define a full URL to work when developing. In addition to that you need to include the @vite/client to make hot reloading work. This requires you to include multiple script assets when using a custom panel.js as well.

Right now I use the panel.route:after hook to inject the tags with a regex to make it work. But in general I think this might be useful outside of vite as well.

@distantnative distantnative self-assigned this Sep 9, 2023
@distantnative distantnative added this to the 4.0.0-beta.2 milestone Sep 9, 2023
@distantnative distantnative linked a pull request Sep 9, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants