Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple Panel assets and absolute URLs #5602

Merged

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Sep 9, 2023

This PR …

@lukaskleinschmidt Could you please test if this is what you had in mind with your issue?

Enhancement

  • panel.css and panel.js config options now also support arrays with multiple entries as well as absolute URLs

Breaking changes

  • Pane\Assets::custom() now returns an array

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative self-assigned this Sep 9, 2023
@distantnative distantnative force-pushed the v4/enhancement/5180-panel-assets-multiple branch from f12106c to bf3dc83 Compare September 9, 2023 13:39
@distantnative distantnative force-pushed the v4/enhancement/5180-panel-assets-multiple branch from bf3dc83 to 22bbf74 Compare September 9, 2023 13:46
@distantnative distantnative linked an issue Sep 9, 2023 that may be closed by this pull request
@distantnative distantnative marked this pull request as ready for review September 9, 2023 13:58
@distantnative distantnative requested a review from a team September 9, 2023 13:59
@lukaskleinschmidt
Copy link
Contributor

Works like a charm

@bastianallgeier bastianallgeier merged commit fa240e1 into v4/develop Sep 12, 2023
@bastianallgeier bastianallgeier deleted the v4/enhancement/5180-panel-assets-multiple branch September 12, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow URLs and multiple custom panel styles/scripts
3 participants