Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] toUrl() on Link field with Page that got deleted throws error #5367

Closed
tobimori opened this issue Jul 12, 2023 · 0 comments · Fixed by #5368
Closed

[v4] toUrl() on Link field with Page that got deleted throws error #5367

tobimori opened this issue Jul 12, 2023 · 0 comments · Fixed by #5368
Assignees
@afbora
Milestone
4.0.0-alpha.5

Comments

@tobimori
Copy link
Contributor

Description

Kirby's Url component will throw an error when trying to create the Url for a page that doesn't exist anymore.

Expected behavior
null return, no error; similar to when the field would be empty (it's shown empty in the panel as well).

To reproduce

  1. Create a Link Field
  2. Set a page in such Link Field
  3. Access the URL via $field->toUrl()
  4. Delete the Page
  5. Kirby will throw an error

Your setup

Kirby Version 4.0.0.alpha-4
@afbora afbora added this to the 4.0.0-alpha.5 milestone Jul 13, 2023
@afbora afbora self-assigned this Jul 13, 2023
afbora added a commit that referenced this issue Jul 13, 2023
@afbora
Fix ->toUrl() method for invalid uuids #5367
aff2abc
afbora added a commit that referenced this issue Jul 13, 2023
@afbora
Fix ->toUrl() method for invalid uuids #5367
da13356
@afbora afbora linked a pull request Jul 13, 2023 that will close this issue
Fix ->toUrl() method for invalid uuids #5368
Merged
5 tasks
afbora added a commit that referenced this issue Jul 13, 2023
@afbora
Fix ->toUrl() method for invalid uuids #5367
3324260
afbora added a commit that referenced this issue Jul 13, 2023
@afbora
Fix ->toUrl() method for invalid uuids #5367
83b25a4
afbora added a commit that referenced this issue Jul 14, 2023
@afbora
Throw NotFoundException for invalid uuid #5367
abc8965
@afbora afbora mentioned this issue Jul 14, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afbora afbora

Labels
None yet
Milestone
4.0.0-alpha.5
Development

Successfully merging a pull request may close this issue.

Fix ->toUrl() method for invalid uuids getkirby/kirby
3 participants
@bastianallgeier @afbora @tobimori