Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] Problem deleting images in pages/files field #5623

Closed
lukaskleinschmidt opened this issue Sep 13, 2023 · 1 comment · Fixed by #5624
Closed

[v4] Problem deleting images in pages/files field #5623

lukaskleinschmidt opened this issue Sep 13, 2023 · 1 comment · Fixed by #5624
Assignees
@afbora
Milestone
4.0.0-beta.2

Comments

@lukaskleinschmidt
Copy link
Contributor

Description

There is an issue when deleting images from the gallery block. It seems like the index/key of the image that should be removed is not correct. The gallery.yml from the GIF has been slightly modified, but the problem persists when using the unchanged default gallery block.

I also tested it in a fresh startkit using 4.0.0-beta.1

gallery_block

Your setup

4.0.0-beta.1

Console output

Your system (please complete the following information)

  • Device: Desktop
  • OS: Windows 10
  • Browser: Firefox 118
@lukaskleinschmidt lukaskleinschmidt changed the title [v4] Issue with gallery block [v4] Problem deleting images in gallery block Sep 13, 2023
@afbora afbora added this to the 4.0.0 milestone Sep 13, 2023
@afbora
Copy link
Member

afbora commented Sep 13, 2023 •
edited
Loading

Actually this issue related with picker collection (files/pages field).

@afbora afbora changed the title [v4] Problem deleting images in gallery block [v4] Problem deleting images in files field Sep 13, 2023
@afbora afbora changed the title [v4] Problem deleting images in files field [v4] Problem deleting images in pages/files field Sep 13, 2023
@afbora afbora self-assigned this Sep 13, 2023
@afbora afbora modified the milestones: 4.0.0, 4.0.0-beta.2 Sep 13, 2023
afbora added a commit that referenced this issue Sep 13, 2023
@afbora
Fix collection items index #5623
2d45ac1
@afbora afbora mentioned this issue Sep 13, 2023
Merged
5 tasks
@distantnative distantnative linked a pull request Sep 14, 2023 that will close this issue
Fix collection items index #5624
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afbora afbora

Labels
None yet
Milestone
4.0.0-beta.2
Development

Successfully merging a pull request may close this issue.

Fix collection items index getkirby/kirby
3 participants
@bastianallgeier @afbora @lukaskleinschmidt