Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Nested blocks: Selecting and merging multiple blocks not possible #5626

Closed
SebastianEberlein-JUNO opened this issue Sep 14, 2023 · 8 comments · Fixed by #5841
Closed
Assignees
Milestone

Comments

@SebastianEberlein-JUNO
Copy link

SebastianEberlein-JUNO commented Sep 14, 2023

Description

Splitting blocks inside a nested blocks field works. But I can’t select multiple blocks by holding down CMD and clicking. So merging blocks is not possible.

video.mp4

We use nested blocks to build modular pages. For example, the top level blocks are hero, article and feature. Inside the hero is an image field and a blocks field with fieldsets for headline, subline and button. Inside the article is blocks field with headline, text, quote, ... and so on.

Your setup

v4-beta.1

Edit: Browsers tested: Chrome, Safari, Firefox on macOS

@afbora
Copy link
Member

afbora commented Sep 14, 2023

I think you can't select multiple blocks even standart (not nested) blocks field, right?

@SebastianEberlein-JUNO
Copy link
Author

SebastianEberlein-JUNO commented Sep 14, 2023

You can select multiple blocks by clicking while holding CMD / CTRL. If the blocks have the same block type, the "Merge" button appears.

Screenshot

@afbora
Copy link
Member

afbora commented Sep 14, 2023

Weird! I can't select multiple blocks for any blocks field (Windows 10 & Chrome 116)

@afbora afbora added this to the 4.0.0 milestone Sep 14, 2023
@SebastianEberlein-JUNO
Copy link
Author

SebastianEberlein-JUNO commented Sep 14, 2023

I only tested Chrome, Safari, Firefox on macOS. But when I use https://saucelabs.com/products/cross-browser-testing to test Chrome on Windows 10, I also can’t select multiple blocks in a regular (not-nested) blocks field.

@distantnative
Copy link
Member

It would be super helpful if you could add blueprint examples to reproduce it. Especially with all the nested block/structure etc. topics, it pushes the barrier for debugging a lot higher when one first have to reconstruct the setups from screenshots etc. thanks 🙏 :)

@distantnative distantnative self-assigned this Oct 21, 2023
@distantnative distantnative modified the milestones: 4.0, 4.0.0-beta.3 Oct 21, 2023
distantnative added a commit that referenced this issue Oct 21, 2023

Verified

This commit was signed with the committer’s verified signature.
pradyunsg Pradyun Gedam
distantnative added a commit that referenced this issue Oct 21, 2023
@distantnative distantnative linked a pull request Oct 21, 2023 that will close this issue
@SebastianEberlein-JUNO
Copy link
Author

Sure, here is a simple blueprint that can reproduce the issue in the Plainkit:

site/blueprints/pages/default.yml

title: Default Page
fields:
  blocks:
    type: blocks
    label: Blocks
    fieldsets:
      article:
        name: Article
        preview: fields
        wysiwyg: true
        fields:
          nestedBlocks:
            type: blocks
            label: Nested Blocks
            fieldsets:
              - text

@afbora
Copy link
Member

afbora commented Oct 23, 2023

@distantnative I can't select multiple blocks via CTRL and ALT keys in v4. Only win key works. But in 3.x, CTRL/ALT/WIN keys work great! The issue related with this issue or should I create separate one?

@distantnative
Copy link
Member

Separate. I think we removed some keys as there were complaints with conflicts. But would have to search again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants