Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router fixes for custom views #2942

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Router fixes for custom views #2942

merged 2 commits into from
Nov 23, 2020

Conversation

distantnative
Copy link
Member

Describe the PR

  • Toolbar doesn't disappear anymore when hash is added to custom view route url
  • Removes duplicate store dispatch to view
  • this.$go now supports paths with hash as well

Related issues

@distantnative distantnative self-assigned this Nov 22, 2020
@distantnative distantnative added this to the 3.5.0 milestone Nov 22, 2020
@distantnative distantnative marked this pull request as draft November 22, 2020 11:50
@distantnative distantnative marked this pull request as ready for review November 22, 2020 11:52
@bastianallgeier bastianallgeier merged commit a92338f into features Nov 23, 2020
@bastianallgeier bastianallgeier deleted the fix/2932-router-vustom-views branch November 23, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier