Fix overwriting of Query::$entries
#5307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
For most queries, we pass along a few objects (
kirby
,site
as well asfile
,page
etc.). However, in doing so, we would overwrite the default entry helpers, such aspage()
orfile()
.This PR fixes it by:
It also backports a fix from v4 regarding integer/float arguments. This commit could be skipped in the review.
Fixes
page()
alongside provided objects with the same nameQuery: default
$entries
not available when overwritten by provided$data
#5276Ready?
For review team
Add to website docs release checklist (if needed)