Find::parent(): fix for file with files parent
#5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
force-pushed
the
fix/5273-find-parent-files-path
branch
from
7fee945 to
0f559dd
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
distantnative
force-pushed
the
fix/5273-find-parent-files-path
branch
from
0f559dd to
4e677f7
Compare
bastianallgeier
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Exploding the path at
/files/separator created issues when that segment was multiple times present (due to page's name). Added a regular expression that splits the string only at the last occurrence of/files/.Fixes
lockAPI routes for files that are ancestors of a page calledfilesEditing of File contents not possible when page name is "files" #5273
Ready?
For review team
Add to website docs release checklist (if needed)