Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure field: i18n for column label #5485

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Structure field: i18n for column label #5485

merged 2 commits into from
Aug 19, 2023

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Aug 16, 2023 •
edited
Loading

This PR …

Needed to refactor the general code a bit to add a fix in just one place, not multiple. I think I found also a cleaner and compact solution instead of the if/else-two loops previous one. Would be great to have close eyes whether the refactoring is messing anything else up.

Fixes

Breaking changes

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative added this to the 4.0.0-alpha.7 milestone Aug 16, 2023
@distantnative distantnative requested a review from a team August 16, 2023 11:08
@distantnative distantnative self-assigned this Aug 16, 2023
@distantnative distantnative linked an issue Aug 16, 2023 that may be closed by this pull request
[v4] Structure field: Titles in structure tables in multiple languages not working properly #5483
Closed
@distantnative distantnative force-pushed the v4/fix/5483-structure-i18n-column branch from 68bda0f to 4c074d0 Compare August 16, 2023 11:08
@distantnative distantnative marked this pull request as draft August 16, 2023 11:10
@distantnative distantnative force-pushed the v4/fix/5483-structure-i18n-column branch 2 times, most recently from 1baf241 to 11054c5 Compare August 16, 2023 11:13
@distantnative distantnative marked this pull request as ready for review August 16, 2023 11:40
@distantnative distantnative force-pushed the v4/fix/5483-structure-i18n-column branch from 18e6bdb to a7a4e72 Compare August 17, 2023 12:15
lukasbestle
lukasbestle reviewed Aug 19, 2023
View reviewed changes
Copy link
Member

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clean and a good refactoring. I noticed one breaking change that we may either want to avoid or at least document in the release notes.

config/fields/structure.php Outdated Show resolved Hide resolved
lukasbestle
lukasbestle approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. 👍

@distantnative distantnative merged commit 0f0fcd4 into v4/develop Aug 19, 2023
@distantnative distantnative deleted the v4/fix/5483-structure-i18n-column branch August 19, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasbestle lukasbestle lukasbestle approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

[v4] Structure field: Titles in structure tables in multiple languages not working properly
2 participants
@distantnative @lukasbestle