Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$panel.upload(): use async upload queue #5491

Merged
merged 4 commits into from
Aug 30, 2023
Merged

$panel.upload(): use async upload queue #5491

merged 4 commits into from
Aug 30, 2023

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Aug 17, 2023 •
edited by bastianallgeier
Loading

This PR …

Enhancement

  • $panel.upload() will now only start up to 20 uploads concurrently and adding additional uploads consecutively whenever a previous one finishes

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative added this to the 4.0.0-beta.1 milestone Aug 17, 2023
@distantnative distantnative self-assigned this Aug 17, 2023
@distantnative distantnative requested review from bastianallgeier and removed request for bastianallgeier August 17, 2023 18:30
@distantnative distantnative changed the title V4/enhancement/js upload queue $panel.upload(): use async upload queue Aug 17, 2023
@distantnative distantnative force-pushed the v4/enhancement/js-upload-queue branch from 31b5011 to fc587bc Compare August 17, 2023 18:31
@bastianallgeier bastianallgeier marked this pull request as ready for review August 30, 2023 10:13
@bastianallgeier bastianallgeier self-requested a review August 30, 2023 10:13
bastianallgeier
bastianallgeier approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great

@bastianallgeier bastianallgeier merged commit 4c2c399 into v4/develop Aug 30, 2023
@bastianallgeier bastianallgeier deleted the v4/enhancement/js-upload-queue branch August 30, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier