Reduce JS forEach usage
#5494
Merged
Reduce JS forEach usage
#5494
+83
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
force-pushed
the
v4/refactor/js-foreach
branch
from
bd01a90 to
4ca64bd
Compare
|
Just out of pure curiosity: is this for performance optimisation and is |
|
@ovenum More about consistent coding style. I personally think the for loops are also easier to read and overlook |
|
Thanks for the explanation @distantnative! Relieved that forEach has not some hidden problem i’ve never heard of : ) |
bastianallgeier
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.