Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix $page->isUnlisted() #5506

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix $page->isUnlisted() #5506

merged 1 commit into from
Aug 28, 2023
+84 −3

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Aug 26, 2023 •
edited by bastianallgeier
Loading

This PR …

Fixes

  • Fixed $page->isUnlisted() which falsely would return true for drafts

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

Sorry, something went wrong.

@distantnative distantnative added this to the 3.9.7 milestone Aug 26, 2023
@distantnative distantnative requested a review from a team August 26, 2023 15:47
@distantnative distantnative self-assigned this Aug 26, 2023
@distantnative
Fix $page->isUnlisted()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8dd1d0b
@bastianallgeier bastianallgeier merged commit f810e1d into develop Aug 28, 2023
@bastianallgeier bastianallgeier deleted the fix/page-is-unlisted branch August 28, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier

Assignees

@distantnative distantnative

Labels
None yet
Milestone
3.9.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@distantnative @bastianallgeier