Unify k-text and k-writer #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bastianallgeier It looks like you have now link and list both in k-text but also individual files |
|
And what happened to kbd? |
|
My bad. I didn't clean up those files after moving it back Text.vue. I'm still not 100% decided on the best way to organize the styles. Should they all live in separate files or in a single file? I moved the kbd styles to reset.css because they apply everywhere. I think that's in general a good rule of thumb. |
bastianallgeier
force-pushed
the
v4/enhancements/text-css
branch
from
7870332 to
0a5ccd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I went through a couple more display issues, I realized that we are basically use redundant styles for the writer and the text component. This leaves a lot of room for issues and already created some. I've moved all the text styles into the k-text component and applied k-text to the ProseMirror container. This way we can get rid of all those redundant styles. I fixed a few glitches along the way.
I've added a lot of new test setups for the text component to the sandbox to try all this.