Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color field: fix hsl parsing #5589

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Color field: fix hsl parsing #5589

merged 2 commits into from
Sep 9, 2023

Conversation

distantnative
Copy link
Member

@distantnative distantnative added this to the 4.0.0-beta.2 milestone Sep 9, 2023
@distantnative distantnative requested a review from afbora September 9, 2023 07:20
@distantnative distantnative self-assigned this Sep 9, 2023
@distantnative distantnative marked this pull request as draft September 9, 2023 07:25
@distantnative distantnative linked an issue Sep 9, 2023 that may be closed by this pull request
[v4] Color field HSL deg|rad|grad|turn detection #5580
Closed
@distantnative distantnative marked this pull request as ready for review September 9, 2023 07:46
@afbora
Copy link
Member

afbora commented Sep 9, 2023

How can I test? All this format is correct? hsl(deg|rad|grad|turnINT INT% INT%)

Also I can save the hsl(abc 78% 63%) value. I can see x indicator on the field but saveable (for public status page)

@distantnative
Copy link
Member Author

You can save this string?

hsl(abc 78% 63%)

I can't:
Screenshot 2023-09-09 at 16 15 17

@afbora
Copy link
Member

afbora commented Sep 9, 2023

@distantnative Oh, sorry. I just update dist files 🙈 Forgot to validation part.

@distantnative
Copy link
Member Author

@afbora ok, no worries.

I think all should work:

hsl(180 30% 60%)
hsl(180deg 30% 60%)
hsl(200grad 30% 60%)
hsl(1rad 30% 60%)
hsl(0.25turn 30% 60%)

@distantnative distantnative merged commit ae644fa into v4/develop Sep 9, 2023
@distantnative distantnative deleted the v4/fix/5580-colors-hsl branch September 9, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbora afbora afbora approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

[v4] Color field HSL deg|rad|grad|turn detection
2 participants
@distantnative @afbora