Writer: adding link, insert text when no selected

[distantnative]

This PR …

For the Writer link and email dialog, insert the url/email address when dialog is applied and no text has been selected.

Fixes

• [v4] Writer field: confusing link button with no selection #5661

[afbora]

This PR fixes the issue but broke a behaviour that you can reproduce the issue with following steps:

1. Select a word
2. Insert a link to the word
3. Click to the linked word (not select whole linked text)
4. You'll see link mark is blue as active
5. Click to link button again
6. Update url or title
7. Save and see the issue

[distantnative]

7. Save and see the issue

@afbora Please always describe what's the issue. Best with screenshots or videos. Cause there is always the chance that I or others are not aware of an issue - and then we won't just see it without being pointed directly to it. 😅

I just tried your steps and for me it looks all right:

Screen.Recording.2023-09-24.at.17.00.52.mov

[afbora]

@distantnative Sorry Nico 🙈 You're right. Here my screencast:

link.mp4

Btw this issue not exists for beta.1

[bastianallgeier]

So we need to check if the cursor is already on an existing link

Too quick to review

[bastianallgeier]

It would have been cool to add this to beta.2 but I don't find the time to check out how this could be solved today. Let's fix it in beta.3. I think the issue is pretty clear.

[afbora]

I've pushed a fix about the issue, check out: 30c4859

[distantnative]

@afbora Oh I like the way/idea - need to test it in the next days!👍

[bastianallgeier]

I've just tested it and it works great!