Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New k-colorname-input #5699

Merged
merged 4 commits into from
Sep 27, 2023
Merged

New k-colorname-input #5699

merged 4 commits into from
Sep 27, 2023

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Sep 26, 2023

Features

  • New k-colorname-input

The color name input enhances a regular text field to parse color values and return formatted color strings as value.

Enhancements

  • The color field now also translates valid color names

Refactoring

  • k-color-field now uses the new k-colorname-input

@bastianallgeier bastianallgeier requested a review from a team September 26, 2023 14:55
@bastianallgeier bastianallgeier added this to the 4.0.0-beta.2 milestone Sep 26, 2023
@distantnative
Copy link
Member

distantnative commented Sep 26, 2023

Color field is broken - black background and native color input dialog

Screenshot 2023-09-26 at 19 42 28

Either StringInput must not bind type of the input or we need to explicitly pass type text from colornameinput.

@bastianallgeier
Copy link
Member Author

@distantnative just fixed it.

@bastianallgeier bastianallgeier force-pushed the v4/refactor/colorname-input branch from b727173 to 6d77079 Compare September 27, 2023 10:03
@distantnative distantnative merged commit 912ceec into v4/develop Sep 27, 2023
@distantnative distantnative deleted the v4/refactor/colorname-input branch September 27, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants