Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update check: Warning for EOL PHP versions #5728

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Update check: Warning for EOL PHP versions #5728

merged 1 commit into from
Oct 9, 2023

Conversation

lukasbestle
Copy link
Member

@lukasbestle lukasbestle commented Oct 4, 2023 •
edited by bastianallgeier
Loading

With the EOL of PHP 8.0 coming quite soon, I think it makes sense to warn affected users right in the Panel. The same will apply to all future PHP versions, so I think it makes sense to include this enhancement already in v3.

⚠️ Requires the following PR to getkirby.com: getkirby/getkirby.com#2095

This PR …

Enhancements

  • The System view in the Panel now warns when the used PHP version is end-of-life and no longer receives security updates.

Breaking changes

None

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@lukasbestle lukasbestle added this to the 3.9.8 milestone Oct 4, 2023
@lukasbestle lukasbestle requested a review from a team October 4, 2023 20:20
@lukasbestle lukasbestle self-assigned this Oct 4, 2023
bastianallgeier
bastianallgeier approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!

@bastianallgeier bastianallgeier merged commit 51200f4 into develop Oct 9, 2023
@bastianallgeier bastianallgeier deleted the feature/php-eol-warning branch October 9, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@lukasbestle lukasbestle

Labels
None yet
Milestone
3.9.8
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasbestle @bastianallgeier