Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writer toolbar: fix active nodes #5754

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Writer toolbar: fix active nodes #5754

merged 1 commit into from
Oct 9, 2023

Conversation

distantnative
Copy link
Member

Fixes #5751

This PR …

Fixes

  • Writer toolbar: active nodes are correctly handled
  • Writer toolbar: paragraph node gets removed when editor doc doesn't support it

@distantnative distantnative added this to the 4.0.0-beta.3 milestone Oct 7, 2023
@distantnative distantnative requested review from bastianallgeier and a team October 7, 2023 20:13
@distantnative distantnative self-assigned this Oct 7, 2023
@distantnative distantnative linked an issue Oct 7, 2023 that may be closed by this pull request
[v4] Writer field: non-paragraph node isn't recognised in the dropdown #5751
Closed
@bastianallgeier bastianallgeier merged commit 3fef058 into v4/develop Oct 9, 2023
@bastianallgeier bastianallgeier deleted the v4/fix/5751-writer-active-nodes branch October 9, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.0-beta.3
Development

Successfully merging this pull request may close these issues.

[v4] Writer field: non-paragraph node isn't recognised in the dropdown
2 participants
@distantnative @bastianallgeier