Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writer: support switch from list to paragraph node #5886

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Writer: support switch from list to paragraph node #5886

merged 1 commit into from
Oct 30, 2023

Conversation

distantnative
Copy link
Member

This PR …

Enhancement

  • Writer supports directly switching from a list to paragraph

@distantnative distantnative added this to the 4.1 milestone Oct 29, 2023
@distantnative distantnative self-assigned this Oct 29, 2023
@distantnative distantnative mentioned this pull request Oct 29, 2023
Closed
@bastianallgeier bastianallgeier self-requested a review October 30, 2023 14:49
bastianallgeier
bastianallgeier approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much better!

@bastianallgeier bastianallgeier merged commit 9f61acc into v4/develop Oct 30, 2023
@bastianallgeier bastianallgeier deleted the v4/fix/writer-list-paragraph branch October 30, 2023 14:49
@bastianallgeier bastianallgeier modified the milestones: 4.1, 4.0-beta.3 Oct 30, 2023
@ovenum
Copy link
Contributor

ovenum commented Oct 30, 2023 •
edited
Loading

Will this also work for the Quote node? Could not find it referenced in the commits for this PR.
Just assuming it’s also a node that can contain other nodes and should be handled the same as bulletList and orderedList for a complete fix (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.0-beta.3
Development

Successfully merging this pull request may close these issues.
3 participants
@distantnative @ovenum @bastianallgeier