Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass languageCode argument for some missing hooks #6130

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Pass languageCode argument for some missing hooks #6130

merged 1 commit into from
Jan 15, 2024

Conversation

afbora
Copy link
Member

@afbora afbora commented Jan 9, 2024 •
edited by bastianallgeier
Loading

This PR …

Fixes missing $languageCode argument for site.changeTitle:before and page.changeTitle:before hooks.

Fixes

Breaking changes

May be $languageCode in Site::changeTitle() type hint could be a breaking change, not sure.

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@afbora afbora added this to the 4.1.0 milestone Jan 9, 2024
@afbora afbora requested a review from a team January 9, 2024 12:49
@afbora afbora self-assigned this Jan 9, 2024
@bastianallgeier bastianallgeier merged commit 60e38e1 into develop-minor Jan 15, 2024
11 of 12 checks passed
@bastianallgeier bastianallgeier deleted the fix/6117-language-argument-before-hooks branch January 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@afbora afbora

Labels
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@afbora @bastianallgeier