Support dimensions for avif images
#6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
force-pushed
the
fix/6141-avif-dimensions-support
branch
from
39499b4 to
bf2c020
Compare
bastianallgeier
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
https://php.watch/versions/8.1/gd-avif made me think AVIF support is always there in PHP 8.1 but our CI proofed me wrong. Adding it still is a progressive enhancement as it will still report 0 in PHP 8.1 (so no error) while getting actual results in 8.2
But this is why the unit test is commented out.
Fixes
avifimages (PHP 8.2+ or PHP 8.1 withlibavifcompiled)Ready?
For review team