Skip to content

Structure: Fix regressions from Items refactoring #6181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

lukasbestle
Copy link
Member

@lukasbestle lukasbestle commented Jan 21, 2024

I keep running into Structure issues in v4, now breaking my Downloads Block plugin (which uses a field field inside a structure field).

This PR …

Fixes

  • It is possible again to use the field names field, options, parent, siblings and params inside structure fields
  • $field->toStructure()->field() now returns a copy of the structure field object as intended

Breaking changes

None

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@bastianallgeier bastianallgeier merged commit 7440757 into develop-patch Jan 22, 2024
@bastianallgeier bastianallgeier deleted the fix/structure-regressions branch January 22, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants