-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panel search: abort previous requests #6420
Conversation
cb8223b
to
87b30ab
Compare
There are now quite a few situations where the search is showing "No results" while there's still a search going on in the background that will eventually deliver results. It feels a bit confusing. |
@bastianallgeier tricky one. I think we cannot work with the current boolean |
Yep, makes sense. I also saw yesterday that we need to improve the "no results" part. It should only be shown if nothing is loading and maybe show a "Searching …" placeholder instead if there are no results in the list but loading is still happening. |
87b30ab
to
1c40cf1
Compare
@bastianallgeier I tried to change it, but I am missing something, it still happens for me. Mostly when deleting parts of the query with backspace. |
Starting over with this |
This PR …
Fixes
Search in panel shows old results when response times from server vary #6409
For review team