Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflowing topbar with very long breadcrumb #6559

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix overflowing topbar with very long breadcrumb #6559

merged 2 commits into from
Jul 22, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jul 22, 2024 •
edited by bastianallgeier
Loading

Changelog

Fixes

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 4.4.0 milestone Jul 22, 2024
@distantnative distantnative requested a review from a team July 22, 2024 13:53
@distantnative distantnative self-assigned this Jul 22, 2024
@distantnative distantnative linked an issue Jul 22, 2024 that may be closed by this pull request
[Panel] Pages navigation arrows not visible if breadcrumb to long #6348
Closed
@distantnative distantnative marked this pull request as ready for review July 22, 2024 13:55
bastianallgeier
bastianallgeier approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a min-width to items with icons to keep the icon visible. Otherwise this is a great fix.

@bastianallgeier bastianallgeier merged commit bb6c421 into develop-minor Jul 22, 2024
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/6348-topbar-breadcrumb-overflow branch July 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

[Panel] Pages navigation arrows not visible if breadcrumb to long
2 participants
@distantnative @bastianallgeier