Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix User::roles() for last admin #6693

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix User::roles() for last admin #6693

merged 1 commit into from
Sep 24, 2024

Conversation

distantnative
Copy link
Member

Description

Summary of changes

Clean up from previous PRs: For the last admin

  • We want to limit roles to just their current role when changing roles.
  • But we don't want limit roles when that last admin is creating users.

@distantnative distantnative added this to the 4.5.0 milestone Sep 22, 2024
@distantnative distantnative self-assigned this Sep 22, 2024
This was referenced Sep 22, 2024
Merged
Merged
@distantnative distantnative marked this pull request as ready for review September 23, 2024 16:43
@distantnative distantnative requested a review from a team September 23, 2024 16:43
@bastianallgeier bastianallgeier merged commit b9389d3 into develop-minor Sep 24, 2024
12 checks passed
@bastianallgeier bastianallgeier deleted the fix/user-roles-change branch September 24, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier