Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PageRules::move() one more time #6729

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix PageRules::move() one more time #6729

merged 2 commits into from
Oct 9, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Oct 9, 2024 •
edited
Loading

Description

Summary of changes

  • PageRules::move() now treats pages section with create option correctly

Reasoning

$section->blueprints() doesn't return the template options if the create option is set 😑

Changelog

Fixes

  • Fixed move dialog for parents with pages sections where the create option is set

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative self-assigned this Oct 9, 2024
@distantnative distantnative force-pushed the fix/page-rules-move-one-more-time branch from 5c494e0 to 86b5b00 Compare October 9, 2024 10:39
@distantnative distantnative marked this pull request as ready for review October 9, 2024 10:49
@distantnative distantnative added this to the 4.5.0 milestone Oct 9, 2024
bastianallgeier
bastianallgeier reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test for this?

@distantnative
Copy link
Member Author

@bastianallgeier added it to two existing tests 👍

@bastianallgeier bastianallgeier merged commit 927d925 into develop-minor Oct 9, 2024
12 checks passed
@bastianallgeier bastianallgeier deleted the fix/page-rules-move-one-more-time branch October 9, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

@afbora afbora Awaiting requested review from afbora

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier