fix(netsuite): Aggregator jobs should be unique (#2818)

## Context While syncing invoices to Netsuite, some invoices were sent twice ## Description Add `unique :until_executed` to aggregator jobs so that the resources are only sync'd once.
getlago · Nov 14, 2024 · 0d43376 · 0d43376
1 parent 360e224
commit 0d43376
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 0 deletions.
diff --git a/app/jobs/integrations/aggregator/credit_notes/create_job.rb b/app/jobs/integrations/aggregator/credit_notes/create_job.rb
@@ -6,6 +6,8 @@ module CreditNotes
       class CreateJob < ApplicationJob
         queue_as 'integrations'
 
+        unique :until_executed, on_conflict: :log
+
         retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
         retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 

diff --git a/app/jobs/integrations/aggregator/invoices/create_job.rb b/app/jobs/integrations/aggregator/invoices/create_job.rb
@@ -6,6 +6,8 @@ module Invoices
       class CreateJob < ApplicationJob
         queue_as 'integrations'
 
+        unique :until_executed, on_conflict: :log
+
         retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
         retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 

diff --git a/app/jobs/integrations/aggregator/invoices/crm/create_customer_association_job.rb b/app/jobs/integrations/aggregator/invoices/crm/create_customer_association_job.rb
@@ -7,6 +7,8 @@ module Crm
         class CreateCustomerAssociationJob < ApplicationJob
           queue_as 'integrations'
 
+          unique :until_executed, on_conflict: :log
+
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
           retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 

diff --git a/app/jobs/integrations/aggregator/invoices/crm/create_job.rb b/app/jobs/integrations/aggregator/invoices/crm/create_job.rb
@@ -7,6 +7,8 @@ module Crm
         class CreateJob < ApplicationJob
           queue_as 'integrations'
 
+          unique :until_executed, on_conflict: :log
+
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
           retry_on Integrations::Aggregator::BasePayload::Failure, wait: :polynomially_longer, attempts: 10
           retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100

diff --git a/app/jobs/integrations/aggregator/invoices/crm/update_job.rb b/app/jobs/integrations/aggregator/invoices/crm/update_job.rb
@@ -7,6 +7,8 @@ module Crm
         class UpdateJob < ApplicationJob
           queue_as 'integrations'
 
+          unique :until_executed, on_conflict: :log
+
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
           retry_on Integrations::Aggregator::BasePayload::Failure, wait: :polynomially_longer, attempts: 10
           retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100

diff --git a/app/jobs/integrations/aggregator/payments/create_job.rb b/app/jobs/integrations/aggregator/payments/create_job.rb
@@ -6,6 +6,8 @@ module Payments
       class CreateJob < ApplicationJob
         queue_as 'integrations'
 
+        unique :until_executed, on_conflict: :log
+
         retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 5
         retry_on Integrations::Aggregator::BasePayload::Failure, wait: :polynomially_longer, attempts: 10
         retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100

diff --git a/app/jobs/integrations/aggregator/subscriptions/crm/create_customer_association_job.rb b/app/jobs/integrations/aggregator/subscriptions/crm/create_customer_association_job.rb
@@ -7,6 +7,8 @@ module Crm
         class CreateCustomerAssociationJob < ApplicationJob
           queue_as 'integrations'
 
+          unique :until_executed, on_conflict: :log
+
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
           retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 

diff --git a/app/jobs/integrations/aggregator/subscriptions/crm/create_job.rb b/app/jobs/integrations/aggregator/subscriptions/crm/create_job.rb
@@ -7,6 +7,8 @@ module Crm
         class CreateJob < ApplicationJob
           queue_as 'integrations'
 
+          unique :until_executed, on_conflict: :log
+
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
           retry_on Integrations::Aggregator::BasePayload::Failure, wait: :polynomially_longer, attempts: 10
           retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100

diff --git a/app/jobs/integrations/aggregator/subscriptions/crm/update_job.rb b/app/jobs/integrations/aggregator/subscriptions/crm/update_job.rb
@@ -7,6 +7,8 @@ module Crm
         class UpdateJob < ApplicationJob
           queue_as 'integrations'
 
+          unique :until_executed, on_conflict: :log
+
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
           retry_on Integrations::Aggregator::BasePayload::Failure, wait: :polynomially_longer, attempts: 10
           retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100