hotfix(taxes): Remove charges count from taxes serializer (#2877)

- `count` on API serializer is causing a major performance issue
getlago · Nov 27, 2024 · c59caed · c59caed
1 parent d26aa2b
commit c59caed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/serializers/v1/tax_serializer.rb b/app/serializers/v1/tax_serializer.rb
@@ -13,7 +13,8 @@ def serialize
         add_ons_count: model.add_ons.count,
         customers_count: model.customers_count,
         plans_count: model.plans.count,
-        charges_count: model.charges.count,
+        # DEPRECATED: this is creating a major performance issue
+        # charges_count: model.charges.count,
         commitments_count: model.commitments.count,
         created_at: model.created_at.iso8601
       }

diff --git a/spec/serializers/v1/tax_serializer_spec.rb b/spec/serializers/v1/tax_serializer_spec.rb
@@ -19,7 +19,6 @@
       'add_ons_count' => 0,
       'customers_count' => 0,
       'plans_count' => 0,
-      'charges_count' => 0,
       'created_at' => tax.created_at.iso8601
     )
   end