Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payment_request): Avoid deserialization issues #2815

Merged
merged 1 commit into from
Nov 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions app/services/payment_requests/create_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,12 @@ def call
)
end

SendWebhookJob.perform_later("payment_request.created", payment_request)
after_commit do
SendWebhookJob.perform_later("payment_request.created", payment_request)

payment_result = Payments::CreateService.call(payment_request)
PaymentRequestMailer.with(payment_request:).requested.deliver_later unless payment_result.success?
payment_result = Payments::CreateService.call(payment_request)
PaymentRequestMailer.with(payment_request:).requested.deliver_later unless payment_result.success?
end

result.payment_request = payment_request

Expand Down