Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gocardless): Handle GoCardlessPro::ValidationError when creating payment #2817

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix(gocardless): Handle GoCardlessPro::ValidationError when creating payment #2817

merged 1 commit into from
Nov 14, 2024

Conversation

vincent-pochet
Copy link
Collaborator

Description

This Pull Request adds the handling of GoCardlessPro::ValidationError in the Invoices::Payments::GocardlessService. It will update the invoice with the payment_status = failed and deliver an error webhook to the account owner.

It also adds the call pattern to Invoices::Payments::AdyenService, Invoices::Payments::GocardlessService and Invoices::Payments::StripeService

nudded
nudded approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@nudded nudded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup!

@vincent-pochet vincent-pochet merged commit 3b851d9 into main Nov 14, 2024
6 checks passed
@vincent-pochet vincent-pochet deleted the fix-gocarless-validation-error branch November 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nudded nudded nudded approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-pochet @nudded