Fix(anrok): Taxes not fully applied #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We faced a bug when an invoice has more than one fee related to the same item_id, as in anrok payload we're using the item_id to identify line_item.
as result, we might have more than one line_item with the same item_id - one of them with 0 tax, as fee amount_cents is 0, one with more than 0, as fee amount_cents is not 0, and we can't correctly assign the returned line_item with taxes to the right fee.
Description
when sending a payload to Anrok, send fee.id instead of item_id, as fee_id is uniquely identifies the line_item