misc(daily_usage): Extract daily_usage history from rake task to a service #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
misc-extract-daily-usage-history
branch
from
3c5a99f to
0d9c017
Compare
jdenquin
approved these changes
Nov 21, 2024
vincent-pochet
added a commit
that referenced
this pull request
Nov 21, 2024
## Context Related to #2843 ## Description We missed to move the `require "timecop"` 🤦 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A rake task to fill the history data of the DailyUsage model was recently added (#2751)
Since this task is recomputing the usage for all subscriptions of an organization for a defined number of days, without taking advantage of the usage cache, it can be very slow. Also, an organization can have a large number of subscription, making the current linear approach very inefficient.
Description
This PR extracts the existing logic from the rake task itself in a job/service, taking advantage of sidekiq to parralelize the work