misc: extend tax error details for validationError

app/services/fees/one_off_service.rb

@@ -98,7 +98,7 @@ def apply_provider_taxes(fees_result)
       taxes_result = Integrations::Aggregator::Taxes::Invoices::CreateService.call(invoice:, fees: fees_result)
 
       unless taxes_result.success?
-        create_error_detail(taxes_result.error.code)
+        create_error_detail(taxes_result.error)
 
         return taxes_result
       end
@@ -116,15 +116,17 @@ def apply_provider_taxes(fees_result)
       taxes_result
     end
 
-    def create_error_detail(code)
+    def create_error_detail(error)
       error_result = ErrorDetails::CreateService.call(
         owner: invoice,
         organization: invoice.organization,
         params: {
           error_code: :tax_error,
           details: {
-            tax_error: code
-          }
+            tax_error: error.code
+          }.tap do |details|
+            details[:tax_error_message] = error.error_message if error.code == 'validationError'
+          end
         }
       )
       error_result.raise_if_error!

app/services/invoices/calculate_fees_service.rb

@@ -51,7 +51,7 @@ def call
           taxes_result = fetch_taxes_for_invoice
 
           unless taxes_result.success?
-            create_error_detail(taxes_result.error.code)
+            create_error_detail(taxes_result.error)
 
             # only fail invoices that are finalizing
             invoice.failed! if finalizing_invoice?
@@ -338,15 +338,17 @@ def customer_provider_taxation?
       @customer_provider_taxation ||= invoice.customer.anrok_customer
     end
 
-    def create_error_detail(code)
+    def create_error_detail(error)
       error_result = ErrorDetails::CreateService.call(
         owner: invoice,
         organization: invoice.organization,
         params: {
           error_code: :tax_error,
           details: {
-            tax_error: code
-          }
+            tax_error: error.code
+          }.tap do |details|
+            details[:tax_error_message] = error.error_message if error.code == 'validationError'
+          end
         }
       )
       error_result.raise_if_error!

app/services/invoices/progressive_billing_service.rb

@@ -26,7 +26,7 @@ def call
           taxes_result = Integrations::Aggregator::Taxes::Invoices::CreateService.call(invoice:, fees: invoice.fees)
 
           unless taxes_result.success?
-            create_error_detail(taxes_result.error.code)
+            create_error_detail(taxes_result.error)
             invoice.failed!
 
             return result.service_failure!(code: 'tax_error', message: taxes_result.error.code)
@@ -154,15 +154,17 @@ def customer_provider_taxation?
       @customer_provider_taxation ||= invoice.customer.anrok_customer
     end
 
-    def create_error_detail(code)
+    def create_error_detail(error)
       error_result = ErrorDetails::CreateService.call(
         owner: invoice,
         organization: invoice.organization,
         params: {
           error_code: :tax_error,
           details: {
-            tax_error: code
-          }
+            tax_error: error.code
+          }.tap do |details|
+            details[:tax_error_message] = error.error_message if error.code == 'validationError'
+          end
         }
       )
       error_result.raise_if_error!

app/services/invoices/retry_service.rb

@@ -16,7 +16,7 @@ def call
       taxes_result = Integrations::Aggregator::Taxes::Invoices::CreateService.call(invoice:, fees: invoice.fees)
 
       unless taxes_result.success?
-        create_error_detail(taxes_result.error.code)
+        create_error_detail(taxes_result.error)
         return result.validation_failure!(errors: {tax_error: [taxes_result.error.code]})
       end
 
@@ -109,15 +109,17 @@ def customer
       @customer ||= invoice.customer
     end
 
-    def create_error_detail(code)
+    def create_error_detail(error)
       error_result = ErrorDetails::CreateService.call(
         owner: invoice,
         organization: invoice.organization,
         params: {
           error_code: :tax_error,
           details: {
-            tax_error: code
-          }
+            tax_error: error.code
+          }.tap do |details|
+            details[:tax_error_message] = error.error_message if error.code == 'validationError'
+          end
         }
       )
       error_result.raise_if_error!

spec/fixtures/integration_aggregator/taxes/invoices/api_limit_response.json

@@ -0,0 +1,27 @@
+{
+  "succeededInvoices": [],
+  "failedInvoices": [
+    {
+      "issuing_date": "2024-12-03",
+      "currency": "EUR",
+      "contact": {
+        "external_id": "sync-1-test-1",
+        "name": "sync-1-test-1",
+        "address_line_1": "88 rue du Chemin Vert",
+        "city": "Paris",
+        "zip": "75011",
+        "country": "fr",
+        "taxable": true,
+        "tax_number": "FR86894827773"
+      },
+      "fees": [
+        {
+          "item_id": "sync-1",
+          "item_code": "lago_default_b2b",
+          "amount_cents": 2000
+        }
+      ],
+      "validation_errors": "You've exceeded your API limit of 10 per second"
+    }
+  ]
+}

spec/services/fees/one_off_service_spec.rb

@@ -318,6 +318,28 @@
             expect(invoice.reload.error_details.first.details['tax_error']).to eq('taxDateTooFarInFuture')
           end
         end
+
+        context 'with api limit error' do
+          let(:body) do
+            p = Rails.root.join('spec/fixtures/integration_aggregator/taxes/invoices/api_limit_response.json')
+            File.read(p)
+          end
+
+          it 'returns and store proper error details' do
+            result = one_off_service.create
+
+            aggregate_failures do
+              expect(result).not_to be_success
+              expect(result.error.code).to eq('tax_error')
+              expect(result.error.error_message).to eq('validationError')
+
+              expect(invoice.reload.error_details.count).to eq(1)
+              expect(invoice.reload.error_details.first.details['tax_error']).to eq('validationError')
+              expect(invoice.reload.error_details.first.details['tax_error_message'])
+                .to eq("You've exceeded your API limit of 10 per second")
+            end
+          end
+        end
       end
     end
   end

spec/services/invoices/calculate_fees_service_spec.rb

@@ -235,6 +235,28 @@
               expect(invoice.reload.error_details.first.details['tax_error']).to eq('taxDateTooFarInFuture')
             end
           end
+
+          context 'with api limit error' do
+            let(:body) do
+              p = Rails.root.join('spec/fixtures/integration_aggregator/taxes/invoices/api_limit_response.json')
+              File.read(p)
+            end
+
+            it 'returns and store proper error details' do
+              result = invoice_service.call
+
+              aggregate_failures do
+                expect(result).not_to be_success
+                expect(result.error.code).to eq('tax_error')
+                expect(result.error.error_message).to eq('validationError')
+
+                expect(invoice.reload.error_details.count).to eq(1)
+                expect(invoice.reload.error_details.first.details['tax_error']).to eq('validationError')
+                expect(invoice.reload.error_details.first.details['tax_error_message'])
+                  .to eq("You've exceeded your API limit of 10 per second")
+              end
+            end
+          end
         end
 
         context 'when calculating fees for draft invoice' do

spec/services/invoices/progressive_billing_service_spec.rb

@@ -147,6 +147,30 @@
           expect(invoice.error_details.count).to eq(1)
           expect(invoice.error_details.first.details['tax_error']).to eq('taxDateTooFarInFuture')
         end
+
+        context 'with api limit error' do
+          let(:body) do
+            p = Rails.root.join('spec/fixtures/integration_aggregator/taxes/invoices/api_limit_response.json')
+            File.read(p)
+          end
+
+          it 'returns and store proper error details' do
+            result = create_service.call
+
+            aggregate_failures do
+              expect(result).not_to be_success
+              expect(result.error.code).to eq('tax_error')
+              expect(result.error.error_message).to eq('validationError')
+
+              invoice = customer.invoices.order(created_at: :desc).first
+
+              expect(invoice.reload.error_details.count).to eq(1)
+              expect(invoice.reload.error_details.first.details['tax_error']).to eq('validationError')
+              expect(invoice.reload.error_details.first.details['tax_error_message'])
+                .to eq("You've exceeded your API limit of 10 per second")
+            end
+          end
+        end
       end
     end
 

spec/services/invoices/retry_service_spec.rb

@@ -308,6 +308,37 @@
           expect(invoice.error_details.tax_error.order(created_at: :asc).last.discarded?).to be(false)
         end
       end
+
+      context 'with api limit error' do
+        let(:body) do
+          p = Rails.root.join('spec/fixtures/integration_aggregator/taxes/invoices/api_limit_response.json')
+          File.read(p)
+        end
+
+        it 'keeps invoice in failed status' do
+          result = retry_service.call
+
+          expect(result).not_to be_success
+          expect(result.error).to be_a(BaseService::ValidationFailure)
+          expect(invoice.reload.status).to eq('failed')
+        end
+
+        it 'resolves old tax error and creates new one' do
+          old_error_id = invoice.reload.error_details.last.id
+
+          retry_service.call
+
+          aggregate_failures do
+            expect(invoice.error_details.tax_error.last.id).not_to eql(old_error_id)
+            expect(invoice.error_details.tax_error.count).to be(1)
+            expect(invoice.error_details.tax_error.order(created_at: :asc).last.discarded?).to be(false)
+            expect(invoice.error_details.tax_error.order(created_at: :asc).last.details['tax_error'])
+              .to eq('validationError')
+            expect(invoice.error_details.tax_error.order(created_at: :asc).last.details['tax_error_message'])
+              .to eq("You've exceeded your API limit of 10 per second")
+          end
+        end
+      end
     end
   end
 end