feat(dunning): flag customer as dunning campaign completed on last attempt execution #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the way we are currently resetting customer's dunning campaign status fields is error prone as this is composed by 3 fields and we could leave some behind.
... on dunning campaign attempt execution when customer last attempt count reaches dunning campaign max attempts. Also, use customer dunning_campaign_completed? as guard clause instead of comparing the number of attempts executed against the campaign max attempts
rsempe
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roadmap
👉 https://getlago.canny.io/feature-requests/p/set-up-payment-retry-logic
👉 https://getlago.canny.io/feature-requests/p/send-reminders-for-overdue-invoices
Context
We want to automate dunning process so that our users don't have to look at each customer to maximize their chances of being paid retrying payments of overdue balances and sending email reminders.
We are extending dunning campaigns management to edit and delete campaigns.
Description
Flag customers as dunning campaign completed on last attempt execution, also check the completed flag instead of the campaign max attempts as execution exit condition.
Also, extracts code to reset customer dunning campaign status fields to be reused.