Skip to content

Commit

Permalink
fix(lago-462): remove divider usage in favour of box-shadow
Browse files Browse the repository at this point in the history
  • Loading branch information
keellyp committed Oct 24, 2024
1 parent badd356 commit 3b6a38e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
5 changes: 2 additions & 3 deletions src/components/emails/DunningEmail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
ProviderTypeEnum,
} from '~/generated/graphql'
import { useContextualLocale } from '~/hooks/core/useContextualLocale'
import { Divider } from '~/styles/mainObjectsForm'
import { tw } from '~/styles/utils'

import { Button, Skeleton, Table, Typography } from '../designSystem'
Expand Down Expand Up @@ -91,7 +90,7 @@ export const DunningEmail: FC<DunningEmailProps> = ({

return (
<>
<div className="flex flex-col gap-6">
<div className="flex flex-col gap-6 pb-8 shadow-b">
<Typography className={paragraphStyle} color="textSecondary">
{translate('text_66b378e748cda1004ff00db0', { customerName: customer?.displayName })}
</Typography>
Expand All @@ -118,7 +117,7 @@ export const DunningEmail: FC<DunningEmailProps> = ({
{translate('text_66b378e748cda1004ff00db5')}
</Typography>
</div>
<Divider />

<div className="flex flex-col items-start gap-4">
<div>
<Typography className={captionStyle}>
Expand Down
4 changes: 1 addition & 3 deletions src/pages/settings/Dunnings/CreateDunning.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import {
import { useInternationalization } from '~/hooks/core/useInternationalization'
import { useOrganizationInfos } from '~/hooks/useOrganizationInfos'
import { PageHeader } from '~/styles'
import { Divider } from '~/styles/mainObjectsForm'

gql`
mutation CreateDunningCampaign($input: CreateDunningCampaignInput!) {
Expand Down Expand Up @@ -205,12 +204,11 @@ const CreateDunning = () => {
</div>
{[0, 1].map((_, index) => (
<div key={`loading-${index}`}>
<div className="mb-12 flex flex-col gap-5">
<div className="flex flex-col gap-5 pb-12 shadow-b">
<Skeleton variant="text" width={160} />
<Skeleton variant="text" width={400} />
<Skeleton variant="text" width={296} />
</div>
<Divider />
</div>
))}
</div>
Expand Down
4 changes: 0 additions & 4 deletions src/styles/mainObjectsForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,3 @@ export const SectionTitle = styled(Typography)`
margin-bottom: ${theme.spacing(3)};
}
`

// ------------------------------------------------------------

export const Divider = () => <div className="h-px w-full shadow-b" />

0 comments on commit 3b6a38e

Please sign in to comment.