misc: make sure Netsuite item's data is fully valid before flagging i…

…t as mapped (#1852)
getlago · Nov 6, 2024 · f1248f4 · f1248f4
1 parent c521ddd
commit f1248f4
Showing 1 changed file with 21 additions and 16 deletions.
diff --git a/src/components/settings/integrations/NetsuiteIntegrationItemsListDefault.tsx b/src/components/settings/integrations/NetsuiteIntegrationItemsListDefault.tsx
@@ -50,24 +50,29 @@ const NetsuiteIntegrationItemsListDefault = ({
     subscriptionFee,
     tax,
   } = useMemo(() => {
+    const findDefaultItem = (mappingType: MappingTypeEnum) =>
+      defaultItems?.find(
+        (mapping) =>
+          mapping.mappingType === mappingType &&
+          !!mapping.externalId &&
+          !!mapping.externalName &&
+          !!mapping.externalAccountCode,
+      )
+
     return {
-      fallbackItem: defaultItems?.find(
-        (mapping) => mapping.mappingType === MappingTypeEnum.FallbackItem,
-      ),
-      coupon: defaultItems?.find((mapping) => mapping.mappingType === MappingTypeEnum.Coupon),
-      creditNote: defaultItems?.find(
-        (mapping) => mapping.mappingType === MappingTypeEnum.CreditNote,
-      ),
-      minimumCommitment: defaultItems?.find(
-        (mapping) => mapping.mappingType === MappingTypeEnum.MinimumCommitment,
-      ),
-      prepaidCredit: defaultItems?.find(
-        (mapping) => mapping.mappingType === MappingTypeEnum.PrepaidCredit,
-      ),
-      subscriptionFee: defaultItems?.find(
-        (mapping) => mapping.mappingType === MappingTypeEnum.SubscriptionFee,
+      fallbackItem: findDefaultItem(MappingTypeEnum.FallbackItem),
+      coupon: findDefaultItem(MappingTypeEnum.Coupon),
+      creditNote: findDefaultItem(MappingTypeEnum.CreditNote),
+      minimumCommitment: findDefaultItem(MappingTypeEnum.MinimumCommitment),
+      prepaidCredit: findDefaultItem(MappingTypeEnum.PrepaidCredit),
+      subscriptionFee: findDefaultItem(MappingTypeEnum.SubscriptionFee),
+      tax: defaultItems?.find(
+        (mapping) =>
+          mapping.mappingType === MappingTypeEnum.Tax &&
+          !!mapping.taxCode &&
+          !!mapping.taxNexus &&
+          !!mapping.taxType,
       ),
-      tax: defaultItems?.find((mapping) => mapping.mappingType === MappingTypeEnum.Tax),
     }
   }, [defaultItems])