Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(NavigationTab): use Tailwind #1842

Merged
merged 1 commit into from
Oct 31, 2024
Merged

misc(NavigationTab): use Tailwind #1842

merged 1 commit into from
Oct 31, 2024

Conversation

ansmonjol
Copy link
Collaborator

Context

We're migrating our codebase to replace styled component by tailwind (TW)

Description

This PR does migrate the NavigationTab component to use TW internally.
During the process, it's API and internal behaviour slightly changed:

  • The component does not contain extra wrappers. Meaning that it renders the Tabs component followed by the Tab content directly in the DOM
  • By doing so, it allows to pass a className directly to the Tabs and remove the leftSpacing API in favour of simple TW class usage
  • By default the wrapper has no padding, so all leftSpacing={0} can simply be removed without further action

Fixes LAGO-425

@ansmonjol ansmonjol merged commit 3195462 into main Oct 31, 2024
13 of 14 checks passed
@ansmonjol ansmonjol deleted the navtab-tw branch October 31, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants