misc: continue one Skeleton api migration #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansmonjol
force-pushed
the
skeleton-api-migration
branch
from
90bb269
to
fbcf8ac
Compare
ansmonjol
force-pushed
the
skeleton-api-migration
branch
from
fbcf8ac
to
c17585c
Compare
keellyp
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Skeleton have a new API enforcing the usage of class name rather than props attributes.
Description
This PR makes the skeleton text all use default height (12px).
Also, a circular variant should use the size API rather than setting a width and height with same value each time