misc(Skeleton): use className to define style #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansmonjol
force-pushed
the
skeleton-margins
branch
2 times, most recently
from
44b0393
to
8fc2e89
Compare
ansmonjol
force-pushed
the
skeleton-margins
branch
from
8fc2e89
to
6454461
Compare
ansmonjol
changed the title
ansmonjol
changed the title
keellyp
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The Skeleton component has a new API, preventing to pass margin and width as props but rather use classnames
Description
This PR makes sure all skeleton invocation uses the new API, mostly based on className definitions
Better reviewed commit by commit
Fixes LAGO-492