Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize LagoApiError #55

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Customize LagoApiError #55

merged 4 commits into from
Jan 11, 2023

Conversation

lorddaedra
Copy link
Contributor

@lorddaedra
Copy link
Contributor Author

@jdenquin

@lorddaedra
Copy link
Contributor Author

lorddaedra commented Dec 28, 2022

Ideas for future improvements:

  1. implement API-first approach,
  1. Replace requests with async httpx, https://www.python-httpx.org/async/

Copy link
Collaborator

@lovrocolic lovrocolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @lorddaedra for this PR. We will include it in the next release (probably during this week)

@lorddaedra
Copy link
Contributor Author

I see this warning here:

1 workflow awaiting approval First-time contributors need a maintainer to approve running workflows. Learn more.

Tests worked locally fine on my Python 3.11 dev setup, but I worry about 3.7-3.10. So it's a good idea to approve this PR and run tests on CI before merging.

@jdenquin jdenquin merged commit e3fbbc5 into getlago:main Jan 11, 2023
jdenquin added a commit that referenced this pull request Jan 11, 2023
jdenquin added a commit that referenced this pull request Jan 11, 2023
@jdenquin
Copy link
Contributor

Hello @lorddaedra,

The CI is broken for 3.7 to 3.10 yes!
Could you reopen this PR with the fixes?

@lorddaedra
Copy link
Contributor Author

Hello @lorddaedra,

The CI is broken for 3.7 to 3.10 yes! Could you reopen this PR with the fixes?

Hi! Ok

@lorddaedra lorddaedra mentioned this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants