When launching app window on macOS, make application a foreground app… #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
commented
Jan 7, 2020
| @@ -66,7 +66,7 @@ func onReady() { | |||
| mEnabled.SetTitle("Disabled") | |||
| mEnabled.Disable() | |||
| case <-mUrl.ClickedCh: | |||
| systray.ShowAppWindow("https://www.getlantern.org") | |||
| systray.ShowAppWindow("https://www.github.com/getlantern/lantern") | |||
There was a problem hiding this comment.
Has more interesting UI controls with which to test.
oxtoacart
commented
Jan 7, 2020
| @@ -187,8 +187,6 @@ - (void) quit | |||
|
|
|||
| @end | |||
|
|
|||
| void configureAppWindow(char* title, int width, int height); | |||
There was a problem hiding this comment.
This was already declared in the header, didn't need to re-declare it here.
|
LGTM! |
|
Thanks @atavism! |
ropog3ovomou
pushed a commit
to ropog3ovomou/systray
that referenced
this pull request
Jul 13, 2022
When launching app window on macOS, make application a foreground app…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lication, closes #109