Merge pull request #31 from getlarge/fix-invert-validate-variables-fi…

…lter-condition fix(microservices-shared-env): correct condition in `validate`
getlarge · Feb 28, 2024 · 21dd5c6 · 21dd5c6
2 parents 78986fb + ae5b1d6
commit 21dd5c6
Show file tree

Hide file tree

Showing 18 changed files with 39 additions and 122 deletions.
diff --git a/apps/auth/.eslintrc.json b/apps/auth/.eslintrc.json
@@ -24,7 +24,7 @@
       "parser": "jsonc-eslint-parser",
       "rules": {
         "@nx/dependency-checks": [
-          "error",
+          "warn",
           {
             "buildTargets": ["build"],
             "checkMissingDependencies": true,

diff --git a/apps/auth/package-lock.json b/apps/auth/package-lock.json
diff --git a/apps/auth/package.json b/apps/auth/package.json
@@ -38,7 +38,9 @@
     "ts-mixer": "6.0.1",
     "webpack-node-externals": "3.0.0"
   },
-  "peerDependencies": {},
+  "peerDependencies": {
+    "ioredis": "4.28.5"
+  },
   "peerDependenciesMeta": {
     "ioredis": {
       "optional": true

diff --git a/apps/expiration/.eslintrc.json b/apps/expiration/.eslintrc.json
@@ -19,7 +19,7 @@
       "parser": "jsonc-eslint-parser",
       "rules": {
         "@nx/dependency-checks": [
-          "error",
+          "warn",
           {
             "buildTargets": ["build"],
             "checkMissingDependencies": true,

diff --git a/apps/expiration/package-lock.json b/apps/expiration/package-lock.json
diff --git a/apps/expiration/package.json b/apps/expiration/package.json
@@ -28,6 +28,7 @@
     "dotenv-expand": "10.0.0",
     "fastify": "4.22.0",
     "ioredis": "4.28.5",
+    "mongoose": "6.12.3",
     "nestjs-pino": "3.4.0",
     "pino-http": "8.5.0",
     "reflect-metadata": "0.1.14",

diff --git a/apps/orders/.eslintrc.json b/apps/orders/.eslintrc.json
@@ -19,7 +19,7 @@
       "parser": "jsonc-eslint-parser",
       "rules": {
         "@nx/dependency-checks": [
-          "error",
+          "warn",
           {
             "buildTargets": ["build"],
             "checkMissingDependencies": true,

diff --git a/apps/orders/package-lock.json b/apps/orders/package-lock.json
diff --git a/apps/orders/package.json b/apps/orders/package.json
@@ -44,6 +44,7 @@
     "webpack-node-externals": "3.0.0"
   },
   "peerDependencies": {
+    "ioredis": "4.28.5",
     "uuid": "8.3.2"
   },
   "peerDependenciesMeta": {

diff --git a/apps/payments/.eslintrc.json b/apps/payments/.eslintrc.json
@@ -19,7 +19,7 @@
       "parser": "jsonc-eslint-parser",
       "rules": {
         "@nx/dependency-checks": [
-          "error",
+          "warn",
           {
             "buildTargets": ["build"],
             "checkMissingDependencies": true,

diff --git a/apps/payments/package-lock.json b/apps/payments/package-lock.json
diff --git a/apps/payments/package.json b/apps/payments/package.json
@@ -45,6 +45,7 @@
     "webpack-node-externals": "3.0.0"
   },
   "peerDependencies": {
+    "ioredis": "4.28.5",
     "uuid": "8.3.2"
   },
   "peerDependenciesMeta": {

diff --git a/apps/permissions-manager/.eslintrc.json b/apps/permissions-manager/.eslintrc.json
@@ -19,7 +19,7 @@
       "parser": "jsonc-eslint-parser",
       "rules": {
         "@nx/dependency-checks": [
-          "error",
+          "warn",
           {
             "buildTargets": ["build"],
             "checkMissingDependencies": true,

diff --git a/apps/tickets/.eslintrc.json b/apps/tickets/.eslintrc.json
@@ -24,7 +24,7 @@
       "parser": "jsonc-eslint-parser",
       "rules": {
         "@nx/dependency-checks": [
-          "error",
+          "warn",
           {
             "buildTargets": ["build"],
             "checkMissingDependencies": true,

diff --git a/apps/tickets/package-lock.json b/apps/tickets/package-lock.json
diff --git a/apps/tickets/package.json b/apps/tickets/package.json
@@ -45,6 +45,7 @@
     "webpack-node-externals": "3.0.0"
   },
   "peerDependencies": {
+    "ioredis": "4.28.5",
     "uuid": "8.3.2"
   },
   "peerDependenciesMeta": {

diff --git a/libs/microservices/shared/env/src/validate.ts b/libs/microservices/shared/env/src/validate.ts
@@ -6,7 +6,7 @@ export const validate = <T extends object>(envClass: ClassConstructor<T>) => {
     // eslint-disable-next-line no-param-reassign
     config = Object.fromEntries(
       Object.entries(config).filter(
-        ([, val]) => !val || val === 'null' || val === 'undefined',
+        ([, val]) => !!val && val !== 'null' && val !== 'undefined',
       ),
     );
 

diff --git a/nx.json b/nx.json
@@ -2,6 +2,11 @@
   "affected": {
     "defaultBase": "main"
   },
+  "pluginsConfig": {
+    "@nx/js": {
+      "analyzeSourceFiles": true
+    }
+  },
   "generators": {
     "@nx/react": {
       "application": {