Python 3.7 support #1733
Python 3.7 support #1733
Conversation
|
Coverage increased (+0.1%) to 92.307% when pulling fc3292d09d8ed2db0db773c766241b8c27769487 on yan12125:py37 into a1d095c on spulec:master. |
|
All tests finally pass. Networking on Travis CI VMs is not so stable... |
.travis.yml
Outdated
| @@ -8,6 +8,16 @@ python: | |||
| env: | |||
| - TEST_SERVER_MODE=false | |||
| - TEST_SERVER_MODE=true | |||
| matrix: | |||
There was a problem hiding this comment.
Can you not add 3.7 into the python: list above?
There was a problem hiding this comment.
It doesn't work - https://travis-ci.org/spulec/moto/builds/407918370.
Maybe I should add a comment to remind future visitors about the relevant Travis CI issue?
There was a problem hiding this comment.
Wow that's odd. Yeah add a comment, and if you dont mind, poke travis to see if they're aware of that as I'd think that should "just work"
There was a problem hiding this comment.
Updated!
Yes they are aware - the "sudo + xenial" solution comes from a Travis staff - travis-ci/travis-ci#9815 (comment). Sigh.
|
other than that comment it looks ok |
|
@JackDanger you dont mind testing on 3.7 right? |
|
is there any reason this is not merged yet ?? it would be nice to use python3.7 |
|
@lalithakolla: I believe @JackDanger's approval is required. |
|
No so much required more a second opinion would be nice, worse case in a few days I'll merge. |
Seems @JackDanger is too busy to check this PR. How about just going ahead? |
This is a revised backport of gabrielfalcao/HTTPretty@5776d97 and the following fixup gabrielfalcao/HTTPretty#341
|
Any news? I rebased to the latest master and it still looks good. |
|
Looks great; thanks! |
|
Thanks! But seems the fix is not included in version 1.3.6? And here's something strange for version 1.3.6 - the latest commit on https://github.com/spulec/moto/commits/master is 57f9691, but the 1.3.6 tag is on 4227cfd |
|
Echoing @yan12125's comment here. Any chance of a stable release with 3.7 support soon? (Thanks for building this!) |
As of getmoto#1733, Python 3.7 is supported, so reflect that in the Trove classifiers. As of 2017-09-29, Python 3.3 is end-of-life and no longer receives updates of any kind (including security fixes), so remove it from the list of supported versions.
A large number of the boto unit tests (roughy 1/3rd) were disabled in the past as a result of getmoto/moto#1706 which appears to have been fixed with getmoto/moto#1733 This commit enables the previously disbaled unit tests.
A large number of the boto unit tests (roughy 1/3rd) were disabled in the past as a result of getmoto/moto#1706 which appears to have been fixed with getmoto/moto#1733 This commit enables the previously disbaled unit tests.
Fixes #1706
.travis.ymlis so complicated as Python 3.7 is not fully supported on Travis CI. See travis-ci/travis-ci#9815