Mock more of the Glue Data Catalog APIs #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
force-pushed
the
expand-glue-catalog-mocking
branch
2 times, most recently
from
a6b2c43
to
d92351a
Compare
|
Coverage decreased (-0.4%) to 92.2% when pulling d92351a7777f7224cd364cab75408e862fdccb29 on ashb:expand-glue-catalog-mocking into dfa7935 on spulec:master. |
ashb
force-pushed
the
expand-glue-catalog-mocking
branch
4 times, most recently
from
1dce9f0
to
e8a2ea6
Compare
This adds some of the missing Get/Update/Create APIs relating to the Glue data catalog -- but not yet all of them, and none of the Batch* API calls.
ashb
force-pushed
the
expand-glue-catalog-mocking
branch
from
e8a2ea6
to
5783d66
Compare
|
100% coverage on the moto/glue/* files now. I'm not sure why coverals is reporting a drop in coverage - unless it's a bit noisy some times? Edit it's now updated the coverage figures. PTAL when you have a spare moment @spulec |
|
This is great; thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands on #1750 and adds some more APIs (much easier to have a base to work on! As pointed out in #1561)
This adds some of the missing Get/Update/Create APIs relating to the Glue data catalog -- but not yet all of them, and improves some of the error handling/edge cases when tables or DBs don't exist etc.