Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing users now raise a UserNotFoundException #1883

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Missing users now raise a UserNotFoundException #1883

merged 1 commit into from
Oct 18, 2018

Conversation

georgealton
Copy link
Contributor

resolves #1831

A missing user in a cognito user pool has raises a UserNotFoundException,
not a ResourceNotFoundException. This commit corrects the behaviour so
that the correct exception is raised

@georgealton
Missing users now raise a UserNotFoundException
2d2708c 
A missing user in a cognito user pool has raises a UserNotFoundException,
not a ResourceNotFoundException. This commit corrects the behaviour so
that the correct exception is raised
@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 92.543% when pulling 2d2708c on georgealton:raise_user_not_found_error into 2aad36f on spulec:master.

@spulec spulec merged commit c09b91d into getmoto:master Oct 18, 2018
@spulec
Copy link
Collaborator

spulec commented Oct 18, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cognito-idp admin_get_user should raise a UserNotFoundException, when user not in pool
3 participants
@georgealton @coveralls @spulec