Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AvailabilityZone to describe_db_instances #5373

Conversation

t3hG04T
Copy link
Contributor

@t3hG04T t3hG04T commented Aug 9, 2022

AvailabilityZone information was not printed in create/describe calls for regular RDS.

Resolves #5371

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #5373 (8d1f606) into master (447216c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5373   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         706      706           
  Lines       70527    70529    +2     
=======================================
+ Hits        67709    67711    +2     
  Misses       2818     2818           
Flag Coverage Δ
servertests 35.95% <100.00%> (+<0.01%) ⬆️
unittests 95.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/__init__.py 97.26% <100.00%> (ø)
moto/rds/models.py 93.98% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@t3hG04T t3hG04T force-pushed the feature/add_availability_zone_to_describe_database branch from 8d1f606 to 603000e Compare August 10, 2022 09:21
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this @t3hG04T

@bblommers bblommers merged commit c4965d1 into getmoto:master Aug 10, 2022
@bblommers bblommers added this to the 3.1.18 milestone Aug 10, 2022
@github-actions
Copy link
Contributor

This is now part of moto >= 3.1.18.dev4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rds: AvailabilityZone is not printed out in describe_db_instances
3 participants